removed atexit.register(_umount) to skip umount after each storage ac… #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions fixes : umount is not required for all exists ex. _mount mounpoint will be unmounted before performing any file operation or storage update Signed-off-by: Mayuri Mohite <[email protected]>
chombourger
reviewed
Mar 23, 2021
| @@ -20,7 +20,6 @@ def __init__(self, mtda): | |||
| self.isfuse = False | |||
| self.isloop = False | |||
| self.lock = threading.Lock() | |||
| atexit.register(self._umount) | |||
There was a problem hiding this comment.
we should add a condition for atexit.register() to be called when MTDA is running in daemon/server mode.
There was a problem hiding this comment.
daemon is always running on assist board and while accessing assist board from remote host we start daemon verified with ps -ax | grep mtda-cli > mtda-cli -d -n please provide provide a pointer to handle atexit.register
can we call atexit.register when needed to umount.
Please review need your guidance to handle it correctly
There was a problem hiding this comment.
I guess we could do something like:
if mtda.is_server is True:
atexit.register(self._umount)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions
fixes : umount is not required for all exists ex. _mount mounpoint will be unmounted before
performing any file operation or storage update
Signed-off-by: Mayuri Mohite [email protected]